This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Susurrus please check that this don't broke gtk-rs/gtk#469 |
This was referenced Apr 29, 2017
Might make sense to add a simple test for this, looks good and correct to me apart from that |
No idea how to test it :( |
How did you get the bug? |
@EPashkin You could manually create such a NULL-terminated array of e.g. strings with glib_sys::g_malloc() and ::g_strdup(). When passing that in there it should crash. |
@sdroege, Thanks I don't even think to test it (forgot that it not Gtk and can be tested). |
gtk-rs/gtk#469 is still fixed with this code, but this doesn't seem to fix gtk-rs/examples#119. I'm getting new errors now, like:
But I don't get hard segfaults anymore with no warnings or errors, so I guess that's an improvement. |
@GuillaumeGomez ready for merge |
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert one change from #153
Was wrong replacing g_free with g_strfreev by two reason: